On Thu, Apr 19, 2012 at 4:43 PM, Paolo Bonzini <pbonz...@redhat.com> wrote:
> Il 19/04/2012 10:19, Zhi Yong Wu ha scritto:
>>> >
>>> > 2) The series uses vhost-scsi unconditionally, as far as I can tell. So
>> Perhaps there're some cleanup work to do, but it use vhost-scsi
>> *conditionally*. In virtio_scsi_init(), you can see the code as below:
>> if (s->vhost_scsi) {
>> s->vdev.set_status = virtio_scsi_set_status;
>> }
>> As you have seen, virtio_scsi_set_status will be used to trigger
>> vhost_scsi function.
>
> Ok, I was not sure if that was enough.
>
>>> Even if it actually worked, you need to mention what happens if you
>>> configure SCSI devices on the same virtio-scsi driver that uses vhost.
>> OK, i will do this in next version.
>
> You probably need to stop exposing the SCSI bus altogether if vhost is
> chosen.
There're still some cleanup work to do about how vhost-scsi exists
with virtio-scsi together. I will carefully consider this, thanks.
>
> Paolo
--
Regards,
Zhi Yong Wu
