From: Nicholas Piggin <npig...@gmail.com>
Peter points out double underscore prefix names tend to be reserved
for the system. Clean these up.
Suggested-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Nicholas Piggin <npig...@gmail.com>
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Message-ID: <20240828043337.14587-3-npig...@gmail.com>
---
chardev/char.c | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/chardev/char.c b/chardev/char.c
index 1c7f6c711a..d06698228a 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -633,8 +633,8 @@ static void qemu_chardev_set_replay(Chardev *chr, Error
**errp)
}
}
-static Chardev *__qemu_chr_new_from_opts(QemuOpts *opts, GMainContext *context,
- bool replay, Error **errp)
+static Chardev *do_qemu_chr_new_from_opts(QemuOpts *opts, GMainContext
*context,
+ bool replay, Error **errp)
{
const ChardevClass *cc;
Chardev *base = NULL, *chr = NULL;
@@ -712,12 +712,12 @@ Chardev *qemu_chr_new_from_opts(QemuOpts *opts,
GMainContext *context,
Error **errp)
{
/* XXX: should this really not record/replay? */
- return __qemu_chr_new_from_opts(opts, context, false, errp);
+ return do_qemu_chr_new_from_opts(opts, context, false, errp);
}
-static Chardev *__qemu_chr_new(const char *label, const char *filename,
- bool permit_mux_mon, GMainContext *context,
- bool replay)
+static Chardev *qemu_chr_new_from_name(const char *label, const char *filename,
+ bool permit_mux_mon,
+ GMainContext *context, bool replay)
{
const char *p;
Chardev *chr;
@@ -740,7 +740,7 @@ static Chardev *__qemu_chr_new(const char *label, const
char *filename,
if (!opts)
return NULL;
- chr = __qemu_chr_new_from_opts(opts, context, replay, &err);
+ chr = do_qemu_chr_new_from_opts(opts, context, replay, &err);
if (!chr) {
error_report_err(err);
goto out;
@@ -765,7 +765,8 @@ out:
Chardev *qemu_chr_new_noreplay(const char *label, const char *filename,
bool permit_mux_mon, GMainContext *context)
{
- return __qemu_chr_new(label, filename, permit_mux_mon, context, false);
+ return qemu_chr_new_from_name(label, filename, permit_mux_mon, context,
+ false);
}
static Chardev *qemu_chr_new_permit_mux_mon(const char *label,
@@ -773,7 +774,8 @@ static Chardev *qemu_chr_new_permit_mux_mon(const char
*label,
bool permit_mux_mon,
GMainContext *context)
{
- return __qemu_chr_new(label, filename, permit_mux_mon, context, true);
+ return qemu_chr_new_from_name(label, filename, permit_mux_mon, context,
+ true);
}
Chardev *qemu_chr_new(const char *label, const char *filename,
--
2.47.0
