On Sat, 2 Nov 2024 at 12:57, Bernhard Beschow <shen...@gmail.com> wrote: > > hw/net/imx_fec and hw/net/lan9118 implement the same Ethernet PHY with similar > but not quite the same code. This series consolidates the implementations into > one to fix code duplication. It then continues to make the code more readable > by > reusing some existing constants. > > Having a dedicated module for the PHY allows it to be reused in even further > device models. > > Testing done: > * Run my usual sabrelite load and verify that network works. > * Build and run Buildroot's qemu_arm_vexpress_defconfig which includes lan9118 > and check on serial console that IP address gets assigned. > > v3: > * Don't add SOFT reset, use device-specific method instead (Peter) > * Reuse MII constants for MII_ANLPAR register which was previously missed > * Fix off-by-one error in MII_ANLPAR register which prevented MII constants to > be reused > > v2: > * QOM'ify + mention boards whose migratability will be broken (Peter)
I've added this series to my list of patches to add to target-arm.next once 9.2 is released and we reopen the tree for 10.0. thanks -- PMM
