On 6/9/07, Andreas Färber <[EMAIL PROTECTED]> wrote:
Am 09.06.2007 um 10:05 schrieb Blue Swirl: >> Maybe the bgr detection logic in sdl.c is flawed. Is this patch >> any better? > > Except that on OSX the correct place to fix this would be in > cocoa.m, right? For qemu yes. Works fine on ppc (and if ds->bgr is manually set to 1, shows the blue-footed penguin on ppc). [If the ds->bgr initialization is omitted it hangs with a black screen and the spinning color wheel. That's strange since bgr == 0 would be okay and any other value should lead to a blue-footed penguin only.]
OK, I'll apply the patch.
For Q's interface I derived a patch against host-cocoa/cocoaQemu.m. That works fine on OS X i386 and ppc hosts. > Is there some better way to detect BGR than using the host endianness > like in this version? I have no idea... But are you sure that we do not need 8-bit bgr? Q's patch inverted that, too. How would I test that?
I think there in 8-bit mode the colours come from the palette indexed by the pixel value, not directly from the pixel value.