On Wed, Apr 18, 2012 at 01:57:51PM -0600, Eric Blake wrote: > On 04/18/2012 01:55 PM, Eduardo Habkost wrote: > > The variable is used for the qemu-specific directory and has a different > > meaning of the autoconf "datadir" variable (that's used for the > > $prefix/share directory, not for $prefix/share/PACKAGE). > > Automake uses the name $pkgdatadir for $prefix/share/PACKAGE; is it > worth respinning this patch to s/qemu_datadir/pkgdatadir/ so that our > files have at least a bit more similarity to autotool'd packages?
Personally, I think $qemu_datadir more clear than $pkgdatadir, as the name makes it clear that it's a qemu-specific variable. (But maybe people with more experience with Autotools would say it's the oppposite. I can respin the series if others think it's worth it.) > > > -datadir="\${prefix}/share/qemu" > > +qemu_datadir="\${prefix}/share/qemu" > -- Eduardo