Re: [PATCH v2 02/22] tests/qtest/migration: Standardize hook names

[Fabiano Rosas]

Peter Xu <pet...@redhat.com> writes:

> On Wed, Nov 13, 2024 at 04:46:10PM -0300, Fabiano Rosas wrote:
>>  static void *
>> -test_migration_precopy_tcp_multifd_start_no_zero_page(QTestState *from,
>> +test_migration_precopy_tcp_multifd_no_zero_page_start(QTestState *from,
>
> Looks like this one is leftover to do s/test_migration/migrate_hook/ (and
> below when referenced)?

Good catch! Thanks

>
> Other than that:
>
> Reviewed-by: Peter Xu <pet...@redhat.com>
>
>>                                                        QTestState *to)
>>  {
>> -    test_migrate_precopy_tcp_multifd_start_common(from, to, "none");
>> +    migrate_hook_start_precopy_tcp_multifd_common(from, to, "none");
>>      migrate_set_parameter_str(from, "zero-page-detection", "none");
>>      return NULL;
>>  }