On Wed, Nov 13, 2024 at 04:46:20PM -0300, Fabiano Rosas wrote:
> The migration-test.c file has become unwieldy large. It's quite
> confusing to navigate with all the test definitions mixed with hook
> definitions. The TLS tests make this worse with ifdef'ery.
>
> Since we're planning on having a smaller set of tests to run as smoke
> testing on all architectures, I'm taking the time to split some tests
> into their own file.
>
> Move the TLS tests into a file of their own.
>
> Signed-off-by: Fabiano Rosas <faro...@suse.de>
> ---
> tests/qtest/meson.build | 8 +-
> tests/qtest/migration-test.c | 788 +-----------------------
> tests/qtest/migration/test-framework.h | 6 +
> tests/qtest/migration/tls-tests.c | 791 +++++++++++++++++++++++++
> 4 files changed, 804 insertions(+), 789 deletions(-)
> create mode 100644 tests/qtest/migration/tls-tests.c
>
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index bdb9512510..9ad9f0dc65 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -337,11 +337,13 @@ migration_files = [files(
> 'migration/migration-util.c',
> )]
>
> +migration_tls_files = []
> if gnutls.found()
> - migration_files += [files('../unit/crypto-tls-psk-helpers.c'), gnutls]
> + migration_tls_files = [files('migration/tls-tests.c'),
> + files('../unit/crypto-tls-psk-helpers.c'), gnutls]
Nit: not a meson expert, but I think we could simply use files(A, B)
instead of files(A), files(B)..
Acked-by: Peter Xu <pet...@redhat.com>
--
Peter Xu
