On Tue, 12 Nov 2024 11:14:54 +0100
Mauro Carvalho Chehab <mchehab+hua...@kernel.org> wrote:
> Make error handling within ghes_record_cper_errors() consistent,
> i.e. instead abort just print a error in case ghes GED is not found.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>
Fair enough.
Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com>
> ---
> hw/acpi/ghes.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
> index 1dbcbefbc2ee..e15a411b47e1 100644
> --- a/hw/acpi/ghes.c
> +++ b/hw/acpi/ghes.c
> @@ -377,7 +377,10 @@ void ghes_record_cper_errors(const void *cper, size_t
> len,
>
> acpi_ged_state = ACPI_GED(object_resolve_path_type("", TYPE_ACPI_GED,
> NULL));
> - g_assert(acpi_ged_state);
> + if (!acpi_ged_state) {
> + error_setg(errp, "Can't find ACPI_GED object");
> + return;
> + }
> ags = &acpi_ged_state->ghes_state;
>
> start_addr = le64_to_cpu(ags->ghes_addr_le);
