Re: [PATCH] meson: Add missing SDL dependency to system/main.c

[Paolo Bonzini]

On 11/20/24 12:49, Philippe Mathieu-Daudé wrote:

When building QEMU configure with --disable-gtk --disable-cocoa
on macOS we get:

   ../system/main.c:30:10: fatal error: 'SDL.h' file not found
      30 | #include <SDL.h>
         |          ^~~~~~~
   1 error generated.

Fix by adding the SDL dependency to main.c it's CFLAGS contains
the SDL include directory.

Fixes: 64ed6f92ff ("meson: link emulators without Makefile.target")
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
Looking at commit 88c39c8693 ("Simplify softmmu/main.c") I wonder
if this header is still required.

I think so, SDL has its own main() wrapper.  Anyhow:

Acked-by: Paolo Bonzini <pbonz...@redhat.com>

Thanks,

Paolo

---
  meson.build | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meson.build b/meson.build
index e0b880e4e1..846ffa3834 100644
--- a/meson.build
+++ b/meson.build
@@ -4235,14 +4235,14 @@ foreach target : target_dirs
        'name': 'qemu-system-' + target_name,
        'win_subsystem': 'console',
        'sources': files('system/main.c'),
-      'dependencies': []
+      'dependencies': [sdl]
      }]
      if host_os == 'windows' and (sdl.found() or gtk.found())
        execs += [{
          'name': 'qemu-system-' + target_name + 'w',
          'win_subsystem': 'windows',
          'sources': files('system/main.c'),
-        'dependencies': []
+        'dependencies': [sdl]
        }]
      endif
      if get_option('fuzzing')