18.11.2024 15:39, Philippe Mathieu-Daudé wrote:
On 14/11/24 13:01, Vitaly Kuznetsov wrote:Commit bbf3810f2c4f ("target/i386: Fix conditional CONFIG_SYNDBG enablement") broke !CONFIG_SYNDBG builds as hyperv_syndbg_query_options() is missing there. The idea probably was that as "hv-syndbg" is now under '#ifdef CONFIG_SYNDBG', hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNDBG) cannot be true anyway.It would have been possible to add a stub for hyperv_syndbg_query_options() instead of resurrecting '#ifdef CONFIG_SYNDBG' but avoiding HV_X64_MSR_SYNDBG_OPTIONS altogether instead of zeroing it when !CONFIG_SYNDBG seems preferable. Reported-by: Michael Tokarev <m...@tls.msk.ru> Fixes: bbf3810f2c4f ("target/i386: Fix conditional CONFIG_SYNDBG enablement") Signed-off-by: Vitaly Kuznetsov <vkuzn...@redhat.com> --- target/i386/kvm/kvm.c | 2 ++ 1 file changed, 2 insertions(+)Patch queued to hw-misc, thanks.
Please note once again there's another fix from pbonzini for this. /mjt
