On 11/14/24 08:01, Richard Henderson wrote:
Unify 3 instances of tlb lookup, through tlb_hit, tlbtree_hit,
and tlb_full_align. Use structures to avoid too many arguments.
Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
---
This is a great simplification.
+static void tlb_lookup_nofail(CPUState *cpu, TLBLookupOutput *o,
+ const TLBLookupInput *i)
+{
+ bool ok = tlb_lookup(cpu, o, i);
+ tcg_debug_assert(ok);
From the function name, would that be safe to use a normal assert
instead? In case we have a weird bug coming in the future, it would
expose it more easily.
For the rest,
Reviewed-by: Pierrick Bouvier <pierrick.bouv...@linaro.org>
