Paolo Bonzini <pbonz...@redhat.com> writes:
> Il mar 12 nov 2024, 04:17 Junjie Mao <junjie....@hotmail.com> ha scritto: > > Making a universal unexpected_cfgs apply to the whole workspace may lead > to a lengthy cfg list when more devices in Rust are added. As cargo does > not allow overriding workspace-defined lints once inherited, I think it > better to keep unexpected_cfgs crate-specific. > > Is it possible? I thought you cannot override at a finer granularity once you > have a "workspace = true" line. No, such overriding is not supported by cargo today. I'm thinking about removing the workspace.lints.rust section, but ... > > Based on the experience with C we shouldn't have many cfgs, but if it's > possible I would definitely make unexpected_cfgs specific to qemu-api. ... a quick grep finds 33 different CONFIG_* being used in C under hw/. In that case one universal list of expected cfgs does not look like a problem. Thanks for pointing this out. -- Best Regards Junjie Mao > > Paolo >
