CCing Thomas.

commit 956a78118bfc7fa512b03cbe8a77b9384c6d89f4
Author: Thomas Huth <h...@tuxfamily.org>
Date:   Sat Jun 30 08:45:25 2018 +0200

      m68k: Add NeXTcube machine
It is still quite incomplete (no SCSI, no floppy emulation, no network,
      etc.), but the firmware already shows up the debug monitor prompt in the
      framebuffer display, so at least the very basics are already working.
This code has been taken from Bryce Lanham's GSoC 2011 NeXT branch at https://github.com/blanham/qemu-NeXT/blob/next-cube/hw/next-cube.c and altered quite a bit to fit the latest interface and coding conventions
      of the current QEMU.

Staring at that link, the code was

    /* MMIO */
    cpu_register_physical_memory((uint32_t)0x2000000,0xD0000,
        cpu_register_io_memory(mmio_read, mmio_write, (void 
*)env,DEVICE_NATIVE_ENDIAN));
/* BMAP */ //acts as a catch-all for now
    cpu_register_physical_memory((uint32_t)0x2100000,0x3A7FF,
        cpu_register_io_memory(scr_read, scr_write, (void 
*)env,DEVICE_NATIVE_ENDIAN));

Which we converted to

    /* MMIO */
    memory_region_init_io(mmiomem, NULL, &mmio_ops, machine, "next.mmio",
                          0xD0000);
    memory_region_add_subregion(sysmem, 0x02000000, mmiomem);

    /* BMAP memory */
    memory_region_init_ram_shared_nomigrate(bmapm1, NULL, "next.bmapmem", 64,
                                            true, &error_fatal);
    memory_region_add_subregion(sysmem, 0x020c0000, bmapm1);


So likely the "true" was added by mistake.


--
Cheers,

David / dhildenb


Reply via email to