HI Peter, > From: Peter Maydell <peter.mayd...@linaro.org> > Sent: Wednesday, November 6, 2024 1:01 PM > To: Salil Mehta <salil.me...@huawei.com> > > On Tue, 5 Nov 2024 at 22:20, Salil Mehta <salil.me...@huawei.com> wrote: > > > > HI Peter, > > > > > From: Peter Maydell <peter.mayd...@linaro.org> > > > Sent: Monday, November 4, 2024 1:27 PM > > > To: Salil Mehta <salil.me...@huawei.com> > > > > > > On Sun, 3 Nov 2024 at 15:25, Salil Mehta <salil.me...@huawei.com> > wrote: > > > > > > > > Extract common GIC and CPU interrupt wiring code to improve code > > > > readability and modularity, supporting reuse in future patch sets. > > > > This refactor is benign and introduces *no* functional changes. > > > > > > > > Note: This patch has been isolated from a larger patch set to > > > > facilitate early merging and reduce the complexity of the original > > > > set, as it operates independently. All original tags and author > > > > contributions are retained. > > > > > > I would prefer to see refactoring patches in the context of the > > > series that makes them necessary. As it stands, there doesn't > > > really seem to be much benefit to this change. > > > > > > Ok no issues. Just to confirm, your above comment is just specific to > > this patch or all the 3 individual patches I had sent for review? > > It applies to all of them (and as a general principle).
Got it. I thought changes in below patches were in any case useful as they were improving the code? https://lore.kernel.org/qemu-devel/20241103152256.202444-1-salil.me...@huawei.com/ https://lore.kernel.org/qemu-devel/20241103152639.202480-1-salil.me...@huawei.com/ Thanks > > thanks > -- PMM
