On Mon, Apr 16, 2012 at 02:28:20PM -0600, Eric Blake wrote:
> On 04/15/2012 01:59 PM, Michael Tokarev wrote:
> > On 15.04.2012 06:48, Kevin O'Connor wrote:
> >> The 1.7.0 version of SeaBIOS has now been released. For more
> >> information on the release, please see:
> >>
> >> http://seabios.org/Releases
> >
> > Um. I can't compile it here, due to an error in ./tools/buildversion.sh.
[...]
> > AFIAK, "==" operator is a bash(?) extension, standard
> > POSIX shell only mentions "=" operator.
>
> Not just a bash extension, as ksh and zsh have it too, but you are right
> that dash doesn't implement it because POSIX 2008 (Issue 7) doesn't
> require '==', just '='. [There is a good chance that the next POSIX
> revision (Issue 8) will require '==' as a synonym for '=', but as that
> version of POSIX is still several years away, you're still better off
> sticking to '=' for now.]
It's easy enough to fix in SeaBIOS (for the next release).
-Kevin
>From 385a7d0dec28841a05531cba96c62138c3959fef Mon Sep 17 00:00:00 2001
From: Kevin O'Connor <ke...@koconnor.net>
Date: Sun, 15 Apr 2012 22:02:15 -0400
Subject: [PATCH] buildversion: Don't rely on bash syntax.
To: seab...@seabios.org
Use '=' instead of '=='.
Signed-off-by: Kevin O'Connor <ke...@koconnor.net>
---
tools/buildversion.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/buildversion.sh b/tools/buildversion.sh
index 9b301e6..c8c1725 100755
--- a/tools/buildversion.sh
+++ b/tools/buildversion.sh
@@ -15,7 +15,7 @@ VERSION="${VERSION}-`date +"%Y%m%d_%H%M%S"`-`hostname`"
echo "Version: ${VERSION}"
# Build header file
-if [ "$VAR16MODE" == "VAR16" ]; then
+if [ "$VAR16MODE" = "VAR16" ]; then
cat > ${OUTFILE} <<EOF
#include "types.h"
char VERSION[] VAR16 = "${VERSION}";
--
1.7.6.5
