On 2024/11/5 11:11, Duan, Zhenzhong wrote:
+ DEFINE_PROP_BOOL("x-fls", IntelIOMMUState, scalable_modern, FALSE),
DEFINE_PROP_BOOL("snoop-control", IntelIOMMUState, snoop_control,
false),
a question: is there any requirement on the layout of this array? Should
new fields added in the end?
Looked over the history, seems we didn't have an explicit rule in
vtd_properties.
I put "x-fls" just under "x-scalable-mode" as stage-1 is a sub-feature of
scalable
mode.
Let me know if you have preference to add in the end.
I don't have a preference for now as long as it does not break any
functionality. BTW. Will x-flt or x-flts better?
So first level support(fls) vs. first level translation(flt) or first level
translation support(flts),
looks same for me, but I can change to x-flt or x-flts if you prefer.
x-flts looks better as it suits more how spec tells it (FSTS in the eap
register). :)
--
Regards,
Yi Liu
