On Sat, Nov 2, 2024 at 8:25 AM Bernhard Beschow <shen...@gmail.com> wrote:
>
> Reviewed-by: Cédric Le Goater <c...@redhat.com>
> Signed-off-by: Bernhard Beschow <shen...@gmail.com>
> ---
> hw/i2c/smbus_eeprom.c | 19 ++++++++-----------
> 1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
> index 9e62c27a1a..1d4d9704bf 100644
> --- a/hw/i2c/smbus_eeprom.c
> +++ b/hw/i2c/smbus_eeprom.c
> @@ -151,19 +151,16 @@ static void smbus_eeprom_class_initfn(ObjectClass
> *klass, void *data)
> dc->user_creatable = false;
> }
>
> -static const TypeInfo smbus_eeprom_info = {
> - .name = TYPE_SMBUS_EEPROM,
> - .parent = TYPE_SMBUS_DEVICE,
> - .instance_size = sizeof(SMBusEEPROMDevice),
> - .class_init = smbus_eeprom_class_initfn,
> +static const TypeInfo types[] = {
This is better, but why did you change the name to "types". The
previous name was fairly descriptive, though you might change "info"
to "types".
-corey
> + {
> + .name = TYPE_SMBUS_EEPROM,
> + .parent = TYPE_SMBUS_DEVICE,
> + .instance_size = sizeof(SMBusEEPROMDevice),
> + .class_init = smbus_eeprom_class_initfn,
> + },
> };
>
> -static void smbus_eeprom_register_types(void)
> -{
> - type_register_static(&smbus_eeprom_info);
> -}
> -
> -type_init(smbus_eeprom_register_types)
> +DEFINE_TYPES(types)
>
> void smbus_eeprom_init_one(I2CBus *smbus, uint8_t address, uint8_t
> *eeprom_buf)
> {
> --
> 2.47.0
>
>
