On Thu, 31 Oct 2024 at 16:55, Michael Tokarev <m...@tls.msk.ru> wrote: > > 29.10.2024 18:10, Peter Maydell wrote: > ... > > (Note for stable backports: the bug goes back to 4a15527c9fee but > > this code was refactored in commits ea8618382aba..a8ab8706d4cc461, so > > fixing it in branches without those refactorings will mean either > > backporting the refactor or else implementing a conceptually similar > > fix for the old code.) > > What do you think is the better way here -- pick up the refactoring > changes (to 9.0 and earlier), do a backport of this single fix, or > do nothing? Note for 7.2 branch it probably requires quite a bit > more work.
The bug being fixed here is a bit niche (I don't think many people build with KVM support only) so I would not worry about backporting it all the way to 7.2. I'm not sure about the best approach for 9.0 (which is why I left that note rather than actively suggestion one or the other) -- it depends whether you value more "backport the change that's actually been tested by being in mainline" or "make the minimal set of changes in the stable branch"... -- PMM
