Hi Andrew and Cedric, ************* Email Confidentiality Notice ******************** 免責聲明: 本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作!
DISCLAIMER: This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you. > -----Original Message----- > From: Andrew Jeffery <and...@codeconstruct.com.au> > Sent: Tuesday, October 22, 2024 7:34 AM > To: Cédric Le Goater <c...@kaod.org>; Jamin Lin <jamin_...@aspeedtech.com>; > Peter Maydell <peter.mayd...@linaro.org>; Steven Lee > <steven_...@aspeedtech.com>; Troy Lee <leet...@gmail.com>; Joel Stanley > <j...@jms.id.au>; Alistair Francis <alist...@alistair23.me>; Kevin Wolf > <kw...@redhat.com>; Hanna Reitz <hre...@redhat.com>; Thomas Huth > <th...@redhat.com>; Laurent Vivier <lviv...@redhat.com>; Paolo Bonzini > <pbonz...@redhat.com>; open list:ASPEED BMCs <qemu-...@nongnu.org>; > open list:All patches CC here <qemu-devel@nongnu.org>; open list:Block layer > core <qemu-bl...@nongnu.org> > Cc: Troy Lee <troy_...@aspeedtech.com>; Yunlin Tang > <yunlin.t...@aspeedtech.com> > Subject: Re: [SPAM] [PATCH v1 11/16] test/qtest/aspeed_smc-test: Support to > test all flash models > > On Mon, 2024-10-21 at 14:39 +0200, Cédric Le Goater wrote: > > On 10/18/24 07:31, Jamin Lin wrote: > > > Currently, these test cases used the hardcode offset 0x1400000 > > > (0x14000 * 256) which was beyond the 16MB flash size for flash page > read/write command testing. > > > However, the default fmc flash model of ast1030-a1 EVB is "w25q80bl" > > > whose size is 1MB. To test all flash models, introduces a new > > > page_addr member in TestData structure, so users can set the offset > > > for flash parge read/write command testing. > > > > The commit title and description are confusing. By "all flash" models, > > do you mean "all Aspeed SoC" models ? > > I think it only relates to the SoCs insofar as the AST1030 embeds some flash > in > the SoC? Otherwise it's dependent on the flash model associated with the > board? > > > > > Since the change is introducing a 'page_addr' data field. I think this > > should be the title. > > I agree that including something about page_addr in the title would be an > improvement. > Thanks for review and suggestion. Will update commit title as following. Introducing a "page_addr" data field Thanks-Jamin > Andrew
