On Mon, Oct 21, 2024 at 06:43:13PM +0200, Cédric Le Goater wrote: > Hello, > > > IIUC the migration thread should always see valid migration object, as it > > takes one refcount at the entrance of migration_thread(): > > > > object_ref(OBJECT(s)); > > Could the migration have failed before ? in migrate_fd_connect()
I just noticed it's a vm state change notifier.. If so, maybe VFIO could refer to its internal states showing that it's during a migration first (so as to guarantee the migration object is valid; e.g., only after save_setup() but before save_cleanup() hooks are invoked). Then migration_file_set_error() is only needed when it's during a migration already. Otherwise it's only a vm state change event, so nothing relevant to migration. -- Peter Xu
