Re: [PATCH v2 8/8] tests/unit/test-char: implement a few mux remove test cases

[Roman Penyaev]

Hi,

On Tue, Oct 15, 2024, 10:50 Marc-André Lureau <marcandre.lur...@redhat.com>
wrote:

[cut]

>      qemu_chr_fe_deinit(&chr_be1, false);
> > -    qemu_chr_fe_deinit(&chr_be2, true);
> > +
> > +    error = NULL;
>
> Unnecessary assignment,
>
> > +    qmp_chardev_remove("mux-label", &error);
> > +    g_assert_cmpstr(error_get_pretty(error), ==, "Chardev 'mux-label'
> is busy");
>
> However, error_free() is missing.
> I'll touch on commit
>
> thanks
>


My bad, thanks for taking care of this.

--
Roman