Michael Tokarev <m...@tls.msk.ru> writes:
> On 14.10.2024 18:15, Daniel P. Berrangé wrote:
>
>> These two lines are the only place in the code that uses the
>> char response[40];
>> so even better than switching to snprintf, how about just taking
>> buffer size out of the picture:
>> g_autofree *response =
>> g_strdup_printf("\033[%d;%dR",
>> (s->y_base + s->y) % s->total_height + 1,
>> s->x + 1);
>> vc_respond_str(vc, response);
>
> What's the reason to perform memory allocation in trivial places
> like this? If we're worrying about possible buffer size issue,
> maybe asprintf() is a better alternative for such small things?
> Fragmenting heap memory for no reason seems too much overkill.
> But I'm old-scool, so.. :)
I doubt the allocate/free pair will cause much fragmentation but it
doesn't look like we are in any hot path here. Anyway snprintf is
certainly better than sprintf so:
Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
>
> /mjt
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
