Hi Salil,
On 2024/10/15 上午3:59, Salil Mehta wrote:
Hi Bibo,
From: maobibo <maob...@loongson.cn>
Sent: Monday, October 14, 2024 9:53 AM
To: qemu-devel@nongnu.org; Salil Mehta <salil.me...@huawei.com>
Cc: Michael S. Tsirkin <m...@redhat.com>; Peter Maydell
<peter.mayd...@linaro.org>; Salil Mehta <salil.me...@huawei.com>;
zhukeqian <zhukeqi...@huawei.com>; Jonathan Cameron
<jonathan.came...@huawei.com>; Gavin Shan <gs...@redhat.com>;
Vishnu Pajjuri <vis...@os.amperecomputing.com>; Xianglai Li
<lixiang...@loongson.cn>; Miguel Luis <miguel.l...@oracle.com>; Shaoqin
Huang <shahu...@redhat.com>; Zhao Liu <zhao1....@intel.com>; Igor
Mammedov <imamm...@redhat.com>; Ani Sinha <anisi...@redhat.com>
Subject: Re: [PULL v2 40/61] hw/acpi: Update GED _EVT method AML with
CPU scan
Hi Salil,
When I debug cpu hotplug on LoongArch system, It reports error like this:
ACPI BIOS Error (bug): Could not resolve symbol [\_SB.GED.CSCN],
AE_NOT_FOUND
ACPI Error: Aborting method \_SB.GED._EVT due to previous error
(AE_NOT_FOUND)
acpi-ged ACPI0013:00: IRQ method execution failed
With this patch, GED CPU call method is "\\_SB.GED.CSCN", however in
function build_cpus_aml(), its method name is "\\_SB.CPUS.CSCN".
method = aml_method(event_handler_method, 0,
AML_NOTSERIALIZED);
aml_append(method, aml_call0("\\_SB.CPUS." CPU_SCAN_METHOD));
aml_append(table, method);
It seems that CPU scanning method name is not consistent between
function build_cpus_aml() and build_ged_aml().
I believe your question stems from the following patch I've sent recently:
https://lore.kernel.org/qemu-devel/20241009031815.250096-16-salil.me...@huawei.com/
I’ve already proposed a fix for this issue. Does that not work for you?
yes, it works for me if AML_GED_EVT_CPU_SCAN_METHOD is used as parameter
in function build_cpus_aml().
Sorry for the noise.
Regards
Bibo Mao
Thanks
Salil.
Regards
Bibo Mao
On 2024/7/23 下午6:59, Michael S. Tsirkin wrote:
> From: Salil Mehta <salil.me...@huawei.com>
>
> OSPM evaluates _EVT method to map the event. The CPU hotplug event
> eventually results in start of the CPU scan. Scan figures out the CPU
> and the kind of
> event(plug/unplug) and notifies it back to the guest. Update the GED
> AML _EVT method with the call to method \\_SB.CPUS.CSCN (via
> \\_SB.GED.CSCN)
>
> Architecture specific code [1] might initialize its CPUs AML code by
> calling common function build_cpus_aml() like below for ARM:
>
> build_cpus_aml(scope, ms, opts, xx_madt_cpu_entry,
memmap[VIRT_CPUHP_ACPI].base,
> "\\_SB", "\\_SB.GED.CSCN", AML_SYSTEM_MEMORY);
>
> [1]
> https://lore.kernel.org/qemu-devel/20240613233639.202896-13-salil.meht
> a...@huawei.com/
>
> Co-developed-by: Keqian Zhu <zhukeqi...@huawei.com>
> Signed-off-by: Keqian Zhu <zhukeqi...@huawei.com>
> Signed-off-by: Salil Mehta <salil.me...@huawei.com>
> Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com>
> Reviewed-by: Gavin Shan <gs...@redhat.com>
> Tested-by: Vishnu Pajjuri <vis...@os.amperecomputing.com>
> Tested-by: Xianglai Li <lixiang...@loongson.cn>
> Tested-by: Miguel Luis <miguel.l...@oracle.com>
> Reviewed-by: Shaoqin Huang <shahu...@redhat.com>
> Tested-by: Zhao Liu <zhao1....@intel.com>
> Reviewed-by: Igor Mammedov <imamm...@redhat.com>
> Message-Id: <20240716111502.202344-5-salil.me...@huawei.com>
> Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
> Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
> ---
> include/hw/acpi/generic_event_device.h | 1 +
> hw/acpi/generic_event_device.c | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/include/hw/acpi/generic_event_device.h
> b/include/hw/acpi/generic_event_device.h
> index e091ac2108..40af3550b5 100644
> --- a/include/hw/acpi/generic_event_device.h
> +++ b/include/hw/acpi/generic_event_device.h
> @@ -87,6 +87,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(AcpiGedState,
ACPI_GED)
> #define GED_DEVICE "GED"
> #define AML_GED_EVT_REG "EREG"
> #define AML_GED_EVT_SEL "ESEL"
> +#define AML_GED_EVT_CPU_SCAN_METHOD "\\_SB.GED.CSCN"
>
> /*
> * Platforms need to specify the GED event bitmap diff --git
> a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
> index 4641933a0f..15b4c3ebbf 100644
> --- a/hw/acpi/generic_event_device.c
> +++ b/hw/acpi/generic_event_device.c
> @@ -108,6 +108,9 @@ void build_ged_aml(Aml *table, const char *name,
HotplugHandler *hotplug_dev,
> aml_append(if_ctx, aml_call0(MEMORY_DEVICES_CONTAINER
"."
> MEMORY_SLOT_SCAN_METHOD));
> break;
> + case ACPI_GED_CPU_HOTPLUG_EVT:
> + aml_append(if_ctx,
aml_call0(AML_GED_EVT_CPU_SCAN_METHOD));
> + break;
> case ACPI_GED_PWR_DOWN_EVT:
> aml_append(if_ctx,
>
> aml_notify(aml_name(ACPI_POWER_BUTTON_DEVICE),
>
