Re: [PATCH v2 10/16] target/mips: Replace MO_TE by mo_endian()

[Philippe Mathieu-Daudé]

On 13/10/24 13:05, Richard Henderson wrote:
On 10/10/24 14:50, Philippe Mathieu-Daudé wrote:
+++ b/target/mips/tcg/msa_helper.c
@@ -8213,7 +8213,7 @@ void helper_msa_ffint_u_df(CPUMIPSState *env, 
uint32_t df, uint32_t wd,
  #if !defined(CONFIG_USER_ONLY)
  #define 
MEMOP_IDX(DF)                                                   \
-    MemOpIdx oi = make_memop_idx(MO_TE | DF | 
MO_UNALN,                 \
+    MemOpIdx oi = make_memop_idx(mo_endian(dc) | DF | 
MO_UNALN,                 \
                                   mips_env_mmu_index(env));
  #else

This one is not within a translation context.
Surely this should be mo_endian_env().

I would have expected this not to compile?

Dead code since commit 948f88661c6 ("target/mips: Use cpu_*_data_ra
for msa load/store"):

$ git grep -w MEMOP_IDX
target/mips/tcg/msa_helper.c:8215:#define MEMOP_IDX(DF) 
                                 \
target/mips/tcg/msa_helper.c:8219:#define MEMOP_IDX(DF)

I'll send a cleanup patch removing the #define lines.


The rest of the changes appear correct, based on filenames.

Might I use your R-b tag on this patch, removing the tcg/msa_helper.c 
change?

Regards,

Phil.