On Mon, 14 Oct 2024, Peter Maydell wrote:
On Sun, 6 Oct 2024 at 17:49, BALATON Zoltan <bala...@eik.bme.hu> wrote:
Rename guest_errors to guest_error to match the log constant
I don't think this is a good reason to change the user-facing
behaviour. Also, I don't think the existing names are so bad:
-d guest_errors
this is plural because we are asking to log all guest errors
qemu_log_mask(LOG_GUEST_ERROR, ...)
this is singular because we are logging a single error here.
If we do want to change things for consistency, we should decide
on what the user-facing option name ought to be (and I think
plural is fine), and then change the internal define to match
that, not vice versa.
The point of this patch is not to match the define with the option.
Originally I had a patch that just separated memory access logs and left
guest_errors as it is but without the memory access logs. But I think
Philippe said that he likes this option to log both. So to satisfy all
needs I'v added this patch to preserve what guest_errors is doing now but
let it be changed later after some time for people to get used to it (or
leave it if that's what people like). Leaving guest_errors to log both is
not an option as I want to have separate options for memory access and
guest errors so they can be turned on or off independently. So if we have
to keep guest_errors to log both then we need a new option for just guest
errors for which one that matches the definen seemed like an easy way that
is consistent with the other debug options. I'd be OK to leave
guest_errors but without the memory access logs, then this patch is not
needed but some people did not like that before.
Regards,
BALATON Zoltan
and print
a warning for -d guest_errors to remind using guest_error,memaccess
instead but preserve previous behaviour for convenience.
Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu>
thanks
-- PMM
