On Mon, 7 Oct 2024 at 12:25, Chao Liu <chao....@yeah.net> wrote: > > Add xilinx zynq board memory mapping is implemented in the device. > > Remove a ignore_memory_transaction_failures concurrently. > > See: ug585-Zynq-7000-TRM manual B.3 (Module Summary) > Signed-off-by: Chao Liu <chao....@yeah.net>
The list of new unimplemented devices looks good. However we do not want to remove ignore_memory_transaction_failures in this patch: (1) patch 3 says it fixes a breakage if we stop ignoring memory transaction failures, so we mustn't turn off the flag until after that point, or we break bisection (2) if we discover a problem with turning off the flag, it's easier to detect and revert if that is done in its own patch, not together with the addition of all the unimplemented-device devices (3) turning off the flag needs to come with a description of all the testing we've done that makes us confident we can do it thanks -- PMM