On Mon, 14 Oct 2024 13:40, Peter Maydell <peter.mayd...@linaro.org> wrote:
>On Mon, 14 Oct 2024 at 11:12, Peter Maydell <peter.mayd...@linaro.org> wrote:
>>
>> On Fri, 11 Oct 2024 at 18:13, Paolo Bonzini <pbonz...@redhat.com> wrote:
>> > v2->v3: new patches
>> > - scripts/archive-source: find directory name for subprojects
>> > - docs: fix invalid footnote syntax
>> > - docs: avoid footnotes consisting of just URLs
>> > - docs: use consistent markup for footnotes
>> >
>> > ----------------------------------------------------------------
>> > * first commit for Rust support
>> > * add CI job using Fedora + Rust nightly
>> > * fix detection of ATOMIC128 on x86_64
>> > * fix compilation with Sphinx 8.1.0
>
>> Applied, thanks.
>
>With this applied, I find that on one of my personal
>local dev branches an incremental rebuild fails, because
>meson complains about not finding a new enough bindgen,
>even though I did not --enable-rust. Meson also complains
>about a bogus coredata.dat and we end up running meson
>three times before it eventually decides the error is fatal.
>
>It looks like meson is incorrectly defaulting to "rust
>enabled" rather than "rust disabled" here ?
>
>[trimmed]
In this pull request, meson_options.txt has:
+option('rust', type: 'feature', value: 'auto',
So it's not disabled by default. It sounds like meson enables the Rust
feature because it found the rustc binary.
