Hi Marc-André, On Wed, Oct 9, 2024 at 8:23 PM Marc-André Lureau <marcandre.lur...@gmail.com> wrote:
[cut] > > > Please rebase, it fails to apply cleanly on master. Yep. > > Can you try to split MuxChardev in a base common class? You could have > MuxBase or simply Mux abstract, with MuxFe (for 'mux') & MuxBe (for > 'mux-be'). This should clarify the code a bit and avoid sharing the same > struct with unused fields. I can give it a try. Let's see how it goes. -- Roman > > Thanks for the tests, that helps a lot! > >> >> chardev/char-fe.c | 14 ++- >> chardev/char-mux.c | 212 +++++++++++++++++++++++++++++++----- >> chardev/char.c | 57 ++++++++-- >> chardev/chardev-internal.h | 33 +++++- >> include/chardev/char.h | 1 + >> qapi/char.json | 9 +- >> qemu-options.hx | 46 +++++++- >> tests/unit/test-char.c | 217 ++++++++++++++++++++++++++++++++++++- >> 8 files changed, 538 insertions(+), 51 deletions(-) >> >> Signed-off-by: Roman Penyaev <r.peni...@gmail.com> >> Cc: "Marc-André Lureau" <marcandre.lur...@redhat.com> >> Cc: qemu-devel@nongnu.org >> >> -- >> 2.43.0 >> >> > > > -- > Marc-André Lureau
