Hi Vladimir On Mon, Sep 30, 2024 at 5:17 PM Vladimir Sementsov-Ogievskiy < vsement...@yandex-team.ru> wrote:
> Hi Mark-Andre! > > Could you please take a look? We have collected acks for QAPI changes, > could this be queued? > > While writing to 9.2 changelog, I realize that we should probably have addressed a few more things: - change -netdev stream to use reconnect-ms too, for consistency - update the qemu documentation to use reconnect-ms - update code and tests to use reconnect-ms Could you look at it? thanks On 13.09.24 12:46, Daniil Tatianin wrote: > > The 'reconnect' option only allows to specify the time in seconds, > > which is way too long for certain workflows. > > > > We have a lightweight disk backend server, which takes about 20ms to > > live update, but due to this limitation in QEMU, previously the guest > > disk controller would hang for one second because it would take this > > long for QEMU to reinitialize the socket connection. > > > > Introduce a new option called 'reconnect-ms', which is the same as > > 'reconnect', except the value is treated as milliseconds. These are > > mutually exclusive and specifying both results in an error. > > > > 'reconnect' is also deprecated by this commit to make it possible to > > remove it in the future as to not keep two options that control the > > same thing. > > > > Reviewed-by: Vladimir Sementsov-Ogievskiy<vsement...@yandex-team.ru> > > Acked-by: Peter Krempa<pkre...@redhat.com> > > Signed-off-by: Daniil Tatianin<d-tatia...@yandex-team.ru> > > -- > Best regards, > Vladimir > > > -- Marc-André Lureau
