On Tue, Oct 08, 2024 at 10:55:45AM +0100, Jonathan Cameron wrote:
> Date: Tue, 8 Oct 2024 10:55:45 +0100
> From: Jonathan Cameron <jonathan.came...@huawei.com>
> Subject: Re: [RFC v2 03/12] system/vl: Create CPU topology devices from CLI
> early
> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32)
>
>
> > +
> > +static void qemu_add_cli_devices_early(void)
> > +{
> > + long category = DEVICE_CATEGORY_CPU_DEF;
> > +
> > + qemu_add_devices(&category);
> > +}
> > +
> > static void qemu_init_board(void)
> > {
> > /* process plugin before CPUs are created, but once -smp has been
> > parsed */
> > @@ -2631,6 +2662,9 @@ static void qemu_init_board(void)
> > /* From here on we enter MACHINE_PHASE_INITIALIZED. */
> > machine_run_board_init(current_machine, mem_path, &error_fatal);
> >
> > + /* Create CPU topology device if any. */
> > + qemu_add_cli_devices_early();
> I wonder if this is too generic a name?
>
> There are various other things we might want to do early.
> Maybe qemu_add_cli_cpu_def()
Sure, it makes sense.
