On Mon, 30 Sept 2024 at 13:38, Francisco Iglesias <francisco.igles...@amd.com> wrote: > > Hi Shiva, > > On the subject: > > s/earse/erase/ > > On Tue, Sep 24, 2024 at 04:50:35PM +0530, Shiva sagar Myana wrote: > > Ensure that the FIFO is checked for emptiness before popping data from it. > > Previously, the code directly popped the data from FIFO without checking, > > which > > I'm not native english speaking but I think "from the FIFO" sounds better to > me! > > > could cause an assertion failure: > > ../util/fifo8.c:67: fifo8_pop: Assertion `fifo->num > 0 > > > > Signed-off-by: Shiva sagar Myana <shivasagar.my...@amd.com> > > With above changes: > > Reviewed-by: Francisco Iglesias <francisco.igles...@amd.com>
Applied to target-arm.next, thanks (with the above commit message tweaks made, and restoring the truncated tail end of the assertion message). -- PMM
