On Sat, 28 Sept 2024 at 12:39, BALATON Zoltan <bala...@eik.bme.hu> wrote:
> > +typedef struct AppleGFXPCIState {
> > + PCIDevice parent_obj;
> > +
> > + AppleGFXState common;
> > +} AppleGFXPCIState;
>
> You don't need typedef here because OBJECT_DECLARE_SIMPLE_TYPE will add
> that. You can also put the struct AppleGFXPCIState definition after the
> OBJECT_DECLARE_SIMPLE_TYPE line. (See other devices for example.)
>
>
Thanks for pointing that out. I've locally applied that advice to this and
the other relevant type declarations in the series, it'll be in v4.
Phil
