Hi Andrew,
> Subject: Re: [PATCH v2 5/6] hw/gpio/aspeed: Add AST2700 support
>
> On Wed, 2024-09-25 at 11:34 +0800, Jamin Lin wrote:
> >
> > + /* interrupt status */
> > + if (SHARED_FIELD_EX32(data, GPIO_CONTROL_INT_STATUS)) {
> > + pending = extract32(set->int_status, pin_idx, 1);
> > + if (pending) {
> > + if (s->pending) {
> > + assert(s->pending >= pending);
> > + s->pending -= pending;
> > + }
> > + set->int_status = deposit32(set->int_status, pin_idx, 1, 0);
> > + }
> > + }
>
> I think you can apply the same reasoning here as on the previous patch.
>
Thanks for review and suggestion.
I am happy to update them in V3.
Thanks-Jamin
> Andrew
