On 12 April 2012 08:41, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 12 April 2012 05:50, Stefan Weil <s...@weilnetz.de> wrote: >> Please use 'uintptr_t' instead of 'unsigned long'. >> >> It does not matter in this special case, but guest_base and >> reserved_va will be changed by my patches for w64 to use >> uintptr_t. The data types 'long' and 'unsigned long' are >> should be avoided. > > Yeah, I was just following the linux-user practice, but if you're > changing those (even though they obviously never get used on w64) > I can make this one uintptr_t too.
... just realised I can't do this, because it would conflict with the extern declaration in cpu-all.h. All the *-user need to change this from unsigned long to uintptr_t at once, so you'll need to do it in your w64 patches I'm afraid. -- PMM
