On Thu, Sep 12, 2024 at 5:56 PM Cédric Le Goater <c...@redhat.com> wrote: > > Hello Jim, > > On 9/12/24 08:36, Jim Shu wrote: > > Hi Cédric, > > > > Thank you very much for the quick response! > > > > I have checked the error API again. It seems to be my porting issue of > > set_iommu_device() callback. > > Are you adding support for a new IOMMU ?
Yes, I am working on RISC-V IOMMU support, based on Zhenzhong's iommufd nesting series [1] and RISC-V IOMMU patch v7. [1] https://github.com/yiliu1765/qemu/commits/zhenzhong/iommufd_nesting_rfcv2 > > > I think "pci_device_set_iommu_device(..., *errp)" should set 'errp' if > > this function returns false, right? > > yes, this is a requirement for routines using an Error parameter. > You can take a look at the "= Rules =" section in include/qapi/error.h > for more info. Thanks for the information! I will take a look. > > Thanks, > > C. >
