On Tue, Sep 10, 2024 at 11:41 AM Si-Wei Liu <si-wei....@oracle.com> wrote:
>
> Hi Jason,
>
> It seems this series wasn't applied successfully, I still cannot see it
> from the latest tree. Any idea?
It breaks make check.
Eugenio, would you want to fix and resend the series?
Thanks
>
> In any case the fix LGTM.
>
> Reviewed-by: Si-Wei Liu <si-wei....@oracle.com>
>
> Thanks,
> -Siwei
>
> On 1/31/2024 9:43 PM, Jason Wang wrote:
> > On Mon, Jan 29, 2024 at 9:24 PM Eugenio Pérez <epere...@redhat.com> wrote:
> >> Commit a0d7215e33 ("vhost-vdpa: do not cleanup the vdpa/vhost-net
> >> structures if peer nic is present") effectively delayed the backend
> >> cleanup, allowing the frontend or the guest to access it resources as
> >> long as the frontend NIC is still visible to the guest.
> >>
> >> However it does not clean up the resources until the qemu process is
> >> over. This causes an effective leak if the device is deleted with
> >> device_del, as there is no way to close the vdpa device. This makes
> >> impossible to re-add that device to this or other QEMU instances until
> >> the first instance of QEMU is finished.
> >>
> >> Move the cleanup from qemu_cleanup to the NIC deletion.
> >>
> >> Fixes: a0d7215e33 ("vhost-vdpa: do not cleanup the vdpa/vhost-net
> >> structures if peer nic is present")
> >> Acked-by: Jason Wang <jasow...@redhat.com>
> >> Reported-by: Lei Yang <leiy...@redhat.com>
> >> Signed-off-by: Eugenio Pérez <epere...@redhat.com>
> >>
> >> Eugenio Pérez (2):
> >> net: parameterize the removing client from nc list
> >> net: move backend cleanup to NIC cleanup
> >>
> >> net/net.c | 30 ++++++++++++++++++++----------
> >> net/vhost-vdpa.c | 8 --------
> >> 2 files changed, 20 insertions(+), 18 deletions(-)
> >>
> >> --
> > Queued.
> >
> > Thanks
> >
>
