On Thu, Sep 05, 2024 at 07:13:23PM +0100, Daniel P. Berrangé wrote: > The virtio-net code for eBPF RSS is still ignoring errors when > failing to load the eBPF RSS program passed in by the mgmt app > via pre-opened FDs. > > This series re-factors the eBPF common code so that it actually > reports using "Error" objects. Then it makes virtio-net treat > a failure to load pre-opened FDs as a fatal problem. When doing > speculative opening of eBPF FDs, QEMU merely prints a warning, > and allows the software fallback to continue. > > Trace event coverage is significantly expanded to make this all > much more debuggable too.
looks good Reviewed-by: Michael S. Tsirkin <m...@redhat.com> Jason's tree. > Changed in v2: > > - Split 'ebpf_error' probe into multiple probes > > Daniel P. Berrangé (7): > hw/net: fix typo s/epbf/ebpf/ in virtio-net > ebpf: drop redundant parameter checks in static methods > ebpf: improve error trace events > ebpf: add formal error reporting to all APIs > hw/net: report errors from failing to use eBPF RSS FDs > ebpf: improve trace event coverage to all key operations > hw/net: improve tracing of eBPF RSS setup > > ebpf/ebpf_rss.c | 118 ++++++++++++++++++++++++++++---------------- > ebpf/ebpf_rss.h | 10 ++-- > ebpf/trace-events | 8 ++- > hw/net/trace-events | 8 +-- > hw/net/virtio-net.c | 63 +++++++++++++++-------- > 5 files changed, 137 insertions(+), 70 deletions(-) > > -- > 2.45.2
