On Thu, Sep 05, 2024 at 09:05:51PM +0200, Thomas Huth wrote:
> On 05/09/2024 20.54, Fabiano Rosas wrote:
> > The vmstate-checker-script test has a bug that makes it flaky. It was
> > also committed by mistake and will be removed.
> >
> > Since the migration-compat job takes the tests from the build-previous
> > job instead of the current HEAD, neither a fix or a removal of the
> > test will take effect for this release.
> >
> > Disable the faulty/undesirable test by taking advantage that it only
> > runs if the PYTHON environment variable is set. This also disables the
> > analyze-migration-script test, but this is fine because that test
> > doesn't have migration compatibility implications.
> >
> > Signed-off-by: Fabiano Rosas <faro...@suse.de>
> > ---
> > .gitlab-ci.d/buildtest.yml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
> > index aa32782405..e52456c371 100644
> > --- a/.gitlab-ci.d/buildtest.yml
> > +++ b/.gitlab-ci.d/buildtest.yml
> > @@ -212,6 +212,12 @@ build-previous-qemu:
> > # testing an old QEMU against new features/tests that it is not
> > # compatible with.
> > - cd build-previous
> > + # Don't allow python-based tests to run. The
> > + # vmstate-checker-script test has a race that causes it to fail
> > + # sometimes. It cannot be fixed it because this job runs the test
> > + # from the old QEMU version. The test will be removed on master,
> > + # but this job will only see the change in the next release.
>
> Maybe explicitly say that this can be removed once 9.2 has been released?
True. I can touch that up if I'm queuing this.
>
> > + - unset PYTHON
> > # old to new
> > - QTEST_QEMU_BINARY_SRC=./qemu-system-${TARGET}
> > QTEST_QEMU_BINARY=../build/qemu-system-${TARGET}
> > ./tests/qtest/migration-test
>
> Reviewed-by: Thomas Huth <th...@redhat.com>
>
--
Peter Xu
