On Thu, Sep 05, 2024 at 08:00:54PM +0200, Denis V. Lunev wrote: > On 9/5/24 19:52, Peter Xu wrote: > > On Thu, Sep 05, 2024 at 06:51:46PM +0200, Denis V. Lunev via wrote: > > > Right now this tracepoint is just saying that the guest has been > > > throttled, but this is not that good for debugging purposes. We should > > > also know how much the guest is throttled in order to understand > > > consequences for the guest behaviour. > > > > > > The patch moves the tracepoint from migration_trigger_throttle() to > > > mig_throttle_guest_down() where this information is really available. > > > This is not a problem as mig_throttle_guest_down() is called in the > > > only one place. > > > > > > Signed-off-by: Denis V. Lunev <d...@openvz.org> > > > CC: Peter Xu <pet...@redhat.com> > > > CC: Fabiano Rosas <faro...@suse.de> > > Makes sense to me, but maybe we can further move it to cpu_throttle_set()? > > > in that case we should rename the tracepoint as in that case the > module would be different :) > > 4 90 system/cpu-throttle.c <<cpu_throttle_set>> > void cpu_throttle_set(int new_throttle_pct) > > Will it be OK for you?
Yes. Thanks. -- Peter Xu
