On Tue, 3 Sept 2024 at 18:15, Paolo Bonzini <pbonz...@redhat.com> wrote:
>
> On Tue, Sep 3, 2024 at 7:04 PM Peter Maydell <peter.mayd...@linaro.org> wrote:
> > The PXA display device doesn't pass anything through to the guest,
> > by the way -- it just draws the pixels in the guest framebuffer
> > in a different place in the UI window. As the FIXME comment in
> > pxa2xx_lcd.c notes, this should really have been done in common
> > code, not in a specific display driver.
>
> spitz also passes it through SPITZ_GPIO_SWB ("Tablet mode"), though
> it's incomplete because it should have treated 180 the same as 0.Whoops, yes -- by the time I got to grepping the sources for uses of the graphic_rotate variable I'd already deleted the spitz.c source file, so I missed that :-) > > As we both note, the UI input layer part *is* generic code so it > > will do the rotation regardless of whether the display device is > > also rotating the guest output. But that seems to me more of > > an accident than an intentional feature. > > Yes, it is, though it *is* working. On the other hand I doubt anyone > is using it. Since we have in the past removed single options like > -alt-grab, whoever needs it can resurrect the code from git and add > the options to -display. They can also add rotation of the output as a > separate knob from rotation of the input. Yeah, I agree. I'll reroll this particular patch separately from the rest and include a paragraph for removed-features.rst specifically documenting that -portrait and -rotate have gone away and why. thanks -- PMM
