On Mon, 2 Sept 2024 at 21:00, Philippe Mathieu-Daudé <phi...@linaro.org> wrote:
>
> On 2/9/24 21:55, Philippe Mathieu-Daudé wrote:
> > Hi Changbin,
> >
> > On 30/8/24 12:53, Changbin Du via wrote:
> >> Print errors before exit. Do not exit silently.
> >>
> >> Signed-off-by: Changbin Du <changbin...@huawei.com>
> >>
> >> ---
> >> v2: remove msg for arm_load_dtb.
> >> ---
> >> hw/arm/boot.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/hw/arm/boot.c b/hw/arm/boot.c
> >> index d480a7da02cf..e15bf097a559 100644
> >> --- a/hw/arm/boot.c
> >> +++ b/hw/arm/boot.c
> >> @@ -839,6 +839,7 @@ static ssize_t arm_load_elf(struct arm_boot_info
>
> Note that header error is also silently ignored and could be logged:
>
> load_elf_hdr(info->kernel_filename, &elf_header, &elf_is64, &err);
> if (err) {
> - error_free(err);
> + error_report_err(err);
> return ret;
> }
>
> (untested)
This one is deliberate -- if the file is not an ELF file
we want to silently fall back to trying it as a uimage or an
AArch64 Image file or as last resort a bare raw binary.
-- PMM
