Gustavo Romero <gustavo.rom...@linaro.org> writes:

> Hi Salil,
>
> On 6/13/24 8:36 PM, Salil Mehta via wrote:
<snip>
>> (VI) Commands Used
>> ==================
>> A. Qemu launch commands to init the machine:
>>      $ qemu-system-aarch64 --enable-kvm -machine virt,gic-version=3
>> \
>>        -cpu host -smp cpus=4,maxcpus=6 \
>>        -m 300M \
>>        -kernel Image \
>>        -initrd rootfs.cpio.gz \
>>        -append "console=ttyAMA0 root=/dev/ram rdinit=/init maxcpus=2 
>> acpi=force" \
>>        -nographic \
>>        -bios QEMU_EFI.fd \
>> B. Hot-(un)plug related commands:
>>    # Hotplug a host vCPU (accel=kvm):
>>      $ device_add host-arm-cpu,id=core4,core-id=4
>>    # Hotplug a vCPU (accel=tcg):
>>      $ device_add cortex-a57-arm-cpu,id=core4,core-id=4
>
> Since support for hotplug is disabled on TCG, remove
> these two lines in v4 cover letter?

Why is it disabled for TCG? We should aim for TCG being as close to KVM
as possible for developers even if it is not a production solution.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Reply via email to