On Tue, Aug 27, 2024 at 03:27:51PM -0400, Stefan Hajnoczi wrote: > qemu_create_cli_devices() should use qmp_device_add() to match the > behavior of the QMP monitor. A comment explained that libvirt changes > implementing strict CLI syntax were needed. > > Peter Krempa <pkre...@redhat.com> has confirmed that modern libvirt uses > the same JSON for -device (CLI) and device_add (QMP). Go ahead and use > qmp_device_add(). > > Cc: Peter Krempa <pkre...@redhat.com> > Reviewed-by: Markus Armbruster <arm...@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > system/vl.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
