On Sun, 25 Aug 2024 at 12:35, Jason A. Donenfeld <ja...@zx2c4.com> wrote: > > On Fri, Aug 23, 2024 at 07:28:43AM +0100, Stafford Horne wrote: > > Also, I will wait to see if Jason has anything to say. > > So long as this doesn't change the assignment of the serial ports to > device nodes in Linux, I don't think this should interfere with much. > You might want to try it, though.
It looks like this board already creates the fdt /aliases/ node and puts uart0, uart1, etc, so that part should be OK. However I notice that the openrisc_sim_serial_init() code will always set the /chosen/stdout-path, so this means (unless I'm misreading the code -- I haven't tested) that the last UART we create will be the stdout-path one. Before this patch, that would be serial_hd(0), but after this it will not be. So I think we probably need to fix this too in the same patch, so that we only set stdout-path for uart0, rather than setting it and then overwriting it on all the subsequent calls. This patch on its own will change the stdout-path value I think. -- PMM
