Am 15. August 2024 09:26:38 UTC schrieb "Philippe Mathieu-Daudé"
<phi...@linaro.org>:
>On 15/8/24 10:24, Mark Cave-Ayland wrote:
>> On 14/08/2024 22:38, BALATON Zoltan wrote:
>>
>>> On Wed, 14 Aug 2024, Bernhard Beschow wrote:
>>>> The serial port's frequency is set via the "baudbase" property nowadays.
>>>
>>> Please keep it as some devices might have registers that set this freq and
>>> this function will be needed for emulating that even if it's not emulated
>>> currently.
>>
>> Why not remove the function if it isn't being used? In general having unused
>> code lying around is bad as it tends to bitrot.
>>
>> If someone did want to re-add this functionality then you would likely want
>> to do it with clock API rather than using a separate function.
>
>I also ended using it in a branch including this old series:
>https://lore.kernel.org/qemu-devel/20200806130340.17316-1-f4...@amsat.org/
>
>Not my priority anymore, so I don't mind re-adding it.
>
This removal seems debatable. I'd err on the safe side and drop the patch in v2.
Any further comments?
