On Wed, 14 Aug 2024 at 05:35, Michael Tokarev <m...@tls.msk.ru> wrote: > > 18.06.2024 16:55, Zheyu Ma wrote: > > This commit adds validation checks for the MCOPRE and MCOSEL values in > > the rcc_update_cfgr_register function. If the MCOPRE value exceeds > > 0b100 or the MCOSEL value exceeds 0b111, an error is logged and the > > corresponding clock mux is disabled. This helps in identifying and > > handling invalid configurations in the RCC registers. > > > > Reproducer: > > cat << EOF | qemu-system-aarch64 -display \ > > none -machine accel=qtest, -m 512M -machine b-l475e-iot01a -qtest \ > > stdio > > writeq 0x40021008 0xffffffff > > EOF > > Is it a -stable material?
No, it's not worthwhile. It turns a case where the guest misprograms the register from an assert to a log-the-error. No real guest code is going to do this. thanks -- PMM
