Re: [PATCH v3 07/20] target/riscv: zicfilp `lpad` impl and branch tracking

[Richard Henderson]

On 8/7/24 10:06, Deepak Gupta wrote:

+++ b/target/riscv/insn32.decode
@@ -40,6 +40,7 @@
  %imm_z6   26:1 15:5
  %imm_mop5 30:1 26:2 20:2
  %imm_mop3 30:1 26:2
+%imm_cfi20 12:20

# Argument sets:

  &empty
@@ -123,7 +124,10 @@ sfence_vm   0001000    00100 ..... 000 00000 1110011 
@sfence_vm

# *** RV32I Base Instruction Set ***

  lui      ....................       ..... 0110111 @u
-auipc    ....................       ..... 0010111 @u
+{
+  lpad     ....................       00000 0010111 %imm_cfi20

IMO, better as

  lpad  imm:20 00000 0010111

without the %imm_cfi20 indirection.


r~