Em Tue, 6 Aug 2024 14:51:53 +0200
Igor Mammedov <imamm...@redhat.com> escreveu:
> > +{ 'struct': 'CommonPlatformErrorRecord',
> > + 'data': {
>
> > + 'notification-type': 'str',
>
> this should be source id (type is just impl. detail of how QEMU delivers
> event for given source id)
> unless there is no plan to use more sources,
> I'd just drop this from API to avoid confusing user.
>
> Since the patch comes before 5/7, it's not clear how it will be used at this
> point.
> I'd move the patch after 5/7.
As described at:
> +# @notification-type: pre-assigned GUID string indicating the record
> +# association with an error event notification type, as defined
> +# at
> https://uefi.org/specs/UEFI/2.10/Apx_N_Common_Platform_Error_Record.html#record-header
This is actually GUID of the error to be generated. Perhaps the better would
be to change the above to:
{ 'struct': 'CommonPlatformErrorRecord',
'data': {
'guid': 'str',
'raw-data': 'str'
}
Making it even clearer. In any case, this is mandatory, as otherwise
the interface would be limited to a single type.
Thanks,
Mauro
