On 7/29/24 10:36 AM, Markus Armbruster wrote:
> David Hildenbrand <da...@redhat.com> writes:
>
>>>>> The simplest way to address 4 is to tack 'if': 'TARGET_S390X' to
>>>>> @deprecated-props.
>>>>>
>>>>
>>>> diff --git a/qapi/machine-target.json b/qapi/machine-target.json
>>>> index 09dec2b9bb..0be95d559c 100644
>>>> --- a/qapi/machine-target.json
>>>> +++ b/qapi/machine-target.json
>>>> @@ -253,7 +253,7 @@
>>>> ##
>>>> { 'struct': 'CpuModelExpansionInfo',
>>>> 'data': { 'model': 'CpuModelInfo',
>>>> - '*deprecated-props': ['str'] },
>>>> + '*deprecated-props' : { 'type': ['str'], 'if': 'TARGET_S390X'
>>>> } },
>>>> 'if': { 'any': [ 'TARGET_S390X',
>>>> 'TARGET_I386',
>>>> 'TARGET_ARM',
>>>>
>>>>
>>>> Should do the trick, right?
>>>
>>> Yes. Break the line before 'if', please.
>>
>> Ack
>>
>> [...]
>>
>>>
>>> Questions?
>>
>> As clear as it can get, thanks! :)
>>
>> That would leave us with:
>
> Looks good to me!
>
>
Fine by me as well. Thanks you both for taking care of this.
--
Regards,
Collin
