Il 03/04/2012 14:30, Andreas Färber ha scritto:
>> > Right now the base Object class has a special NULL type.  Change this so
>> > that we will be able to add class_init and class_base_init callbacks.
>> > To do this, remove some special casing of ObjectClass that is not really
>> > necessary.
> While the patch itself looks good, we should be aware that this changes
> semantics: Before this patch, lack of .parent is identical to .parent =
> TYPE_OBJECT; with this patch that would become another base class.
> Should be mentioned in the commit message and all TypeInfos need to be
> reviewed. I don't think accidentally growing base classes is a good
> idea. Maybe whitelist valid base classes in type_register_static() and
> abort otherwise? Then at least we'd catch it by just running the
> executables.
> 

Good idea.

Paolo

Reply via email to